Add $ln, $log, and $log10 tests#671
Open
danielfrankcom wants to merge 6 commits into
Open
Conversation
This change adds tests for the $ln arithmetic expression. It was originally authored by @mitchell-elholm. Closes documentdb#277 Co-authored-by: Mitchell Elholm <elholmit@amazon.com> Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
This change adds tests for the $log expression. It was originally authored by @mitchell-elholm. Closes documentdb#278 Co-authored-by: Mitchell Elholm <elholmit@amazon.com> Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
This change adds tests for the $log10 expression. It was originally authored by @mitchell-elholm. Closes documentdb#279 Co-authored-by: Mitchell Elholm <elholmit@amazon.com> Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
alinaliBQ
reviewed
Jul 8, 2026
alinaliBQ
left a comment
alinaliBQ
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM, got minor comments
documentdb-triage-tool
Bot
added
compatibility test
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage); effort from diff stats (3321+0 LOC, 22 files); LLM: Adds new compatibility test coverage for $ln, $log, and $log10 arithmetic expressions, closing three tracked issues. If a label is wrong, remove it manually and ping |
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds tests for the
$ln,$log, and$log10arithmetic expressions. They were originally authored by @mitchell-elholm.Closes #277, #278, #279