Skip to content

Add $filter, $in, $indexOfArray, and $isArray tests#667

Open
alinaliBQ wants to merge 21 commits into
documentdb:mainfrom
alinaliBQ:filter-in-indexOfArray-isArray
Open

Add $filter, $in, $indexOfArray, and $isArray tests#667
alinaliBQ wants to merge 21 commits into
documentdb:mainfrom
alinaliBQ:filter-in-indexOfArray-isArray

Conversation

@alinaliBQ

@alinaliBQ alinaliBQ commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This change adds tests for the $filter, $in, $indexOfArray, and $isArray expression. They were originally authored by @leszek-bq.

Closes #291, #292, #293, #294

@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels Jul 6, 2026
@documentdb-triage-tool

documentdb-triage-tool Bot commented Jul 6, 2026

Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort XL · Status In Progress
Confidence: 0.88 (mixed)

Reasoning

component from path globs (test-coverage); effort from diff stats (5749+4 LOC, 37 files); LLM: Adds new test cases for four array expressions ($filter, $in, $indexOfArray, $isArray) plus a new ArrayTestClass definition, expanding compatibility test coverage across multiple operators.

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

@alinaliBQ alinaliBQ marked this pull request as ready for review July 6, 2026 22:55
@alinaliBQ alinaliBQ requested a review from a team as a code owner July 6, 2026 22:55
PatersonProjects
PatersonProjects approved these changes Jul 8, 2026
View reviewed changes
Comment thread documentdb_tests/compatibility/tests/core/operator/expressions/array/in/test_in_errors.py Outdated
Comment thread ...compatibility/tests/core/operator/expressions/array/indexOfArray/test_indexOfArray_errors.py
Comment thread ...tdb_tests/compatibility/tests/core/operator/expressions/array/isArray/test_isArray_errors.py
Comment thread documentdb_tests/compatibility/tests/core/operator/expressions/array/in/test_smoke_in.py
alinaliBQ
alinaliBQ commented Jul 8, 2026
View reviewed changes

@alinaliBQ alinaliBQ left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed Paterson's comments and converted more standalone cases to ExpressionTestCase

Comment thread documentdb_tests/compatibility/tests/core/operator/expressions/array/in/test_in_errors.py Outdated
Comment thread ...compatibility/tests/core/operator/expressions/array/indexOfArray/test_indexOfArray_errors.py
Comment thread ...tdb_tests/compatibility/tests/core/operator/expressions/array/isArray/test_isArray_errors.py
Comment thread documentdb_tests/compatibility/tests/core/operator/expressions/array/in/test_smoke_in.py
danielfrankcom
danielfrankcom reviewed Jul 8, 2026
View reviewed changes
Comment thread ...ests/compatibility/tests/core/operator/expressions/array/filter/test_filter_core_behavior.py Outdated
Comment thread documentdb_tests/compatibility/tests/core/operator/expressions/array/in/test_in_errors.py Outdated
Comment thread documentdb_tests/compatibility/tests/core/operator/expressions/array/in/test_in_null_missing.py Outdated
Comment thread ...db_tests/compatibility/tests/core/operator/expressions/array/filter/test_filter_as_errors.py Outdated
Comment thread ...ompatibility/tests/core/operator/expressions/array/indexOfArray/utils/indexOfArray_common.py Outdated
alinaliBQ
alinaliBQ commented Jul 8, 2026
View reviewed changes

@alinaliBQ alinaliBQ left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressing Daniel's comments. Will work on replacing IndexOfArrayTest with ExpressionTestCase tomorrow

Comment thread ...db_tests/compatibility/tests/core/operator/expressions/array/filter/test_filter_as_errors.py Outdated
Comment thread documentdb_tests/compatibility/tests/core/operator/expressions/array/in/test_in_errors.py Outdated
Comment thread ...ests/compatibility/tests/core/operator/expressions/array/filter/test_filter_core_behavior.py Outdated
Comment thread documentdb_tests/compatibility/tests/core/operator/expressions/array/in/test_in_null_missing.py Outdated
alinaliBQ
alinaliBQ commented Jul 9, 2026
View reviewed changes

@alinaliBQ alinaliBQ left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielfrankcom finished addressing comments. Used constants where applicable

Comment thread ...ompatibility/tests/core/operator/expressions/array/indexOfArray/utils/indexOfArray_common.py Outdated
alinaliBQ added 20 commits July 9, 2026 14:38
@alinaliBQ
migrate filter, in, indexOfArray, isArray
8e1c6f0 
Co-authored-by: Leszek Kurzyna <lkurzyna@amazon.com>
Co-authored-by: Sean Oczkowski <seoc@amazon.com>

Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
Replace InTest with ArrayTestClass
37548e9 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
replace IsArrayTest with ArrayTestClass
529732d 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
update based on review guide
2550543 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
add missing tests
3e8e300 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
regroup tests
060c1a0 
 Moved BOUNDARY_INDEX_TESTS (4 success cases) and NEGATIVE_ZERO_START_TESTS
   (3 success cases) from test_expression_indexOfArray_errors.py →
  test_expression_indexOfArray_core_behavior.py

Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
rename tests and remove dups
c8881ec 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
in-line values
05230fd 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
revert smoke test changes
b7287f3 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
Replace CombinationTest with CombinationTest
552d9e1 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
replace ArrayTestClass with ExpressionTestCase
0b83cbb 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
add back removed tests
7d9a860 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
merge same functions together
5ca0514 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
convert ARITY_ERROR_TESTS to use ExpressionTestCase
1606e79 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
apply style guide changes
330a579 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
convert standalone to use ExpressionTestCase
32a26c3 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
replace float() with FLOAT_
d6c6974 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
clean up comments
c7196e2 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
convert IndexOfArrayTest to use ExpressionTestCase
42d4a45 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
update to use constants
1229d4f 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ alinaliBQ force-pushed the filter-in-indexOfArray-isArray branch from 9dfe1a0 to 1229d4f Compare July 9, 2026 21:39
@alinaliBQ

alinaliBQ commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

will work on the CI failures

@alinaliBQ
wrap large array with lazy()
9044140 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@danielfrankcom danielfrankcom danielfrankcom approved these changes
@PatersonProjects PatersonProjects PatersonProjects approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add compatibility test for $filter

3 participants

@alinaliBQ @danielfrankcom @PatersonProjects