Add $arrayElemAt, $arrayToObject, and $concatArrays tests#666
Open
alinaliBQ wants to merge 16 commits into
Open
Add $arrayElemAt, $arrayToObject, and $concatArrays tests#666alinaliBQ wants to merge 16 commits into
alinaliBQ wants to merge 16 commits into
Conversation
alinaliBQ
force-pushed
the
arrayElemAt-arrayToObject-concatArrays
branch
from
fdb212f to
2310209
Compare
documentdb-triage-tool
Bot
added
compatibility test
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage); effort from diff stats (4474+3 LOC, 27 files); LLM: Adds new compatibility test cases for three array expression operators, spanning multiple test files under the test-coverage component. If a label is wrong, remove it manually and ping |
alinaliBQ
changed the title
danielfrankcom
left a comment
danielfrankcom
left a comment
Collaborator
There was a problem hiding this comment.
A few nitpicks and style questions, but these are primarily just from changes to our approach since these tests were originally written. I didn't find any coverage gaps or major issues
alinaliBQ
force-pushed
the
arrayElemAt-arrayToObject-concatArrays
branch
from
2310209 to
698e430
Compare
alinaliBQ
commented
Jul 7, 2026
alinaliBQ
left a comment
alinaliBQ
left a comment
Contributor
Author
There was a problem hiding this comment.
Addressed comments from Daniel, thanks!
danielfrankcom
approved these changes
Jul 7, 2026
Co-authored-by: Leszek Kurzyna <lkurzyna@amazon.com> Co-authored-by: Sean Oczkowski <seoc@amazon.com> Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
fix flakey test, remove dups, and fix misleading tests Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
alinaliBQ
force-pushed
the
arrayElemAt-arrayToObject-concatArrays
branch
from
6150988 to
0d767c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds tests for the
$arrayElemAt,$arrayToObject, and$concatArraysexpression. They were originally authored by @leszek-bq.Closes #290, #289, #288