Install the nano editor in all images - #17
Merged
Conversation
Add nano to every image and check it in the common smoke test. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017jPxeenJt19PJStMMeb1Em
ENV always set DOCKER_HOST, so the ${DOCKER_HOST:-...} fallback in
/etc/profile could never use its default. The profile now sets both
variables, and a value from the environment is kept.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017jPxeenJt19PJStMMeb1Em
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
nanoto all five images (fx, php, nodejs, golang, python) and check it in the shared smoke test.Changes
*/Dockerfile:nanoappended aftertmuxin the existingapt-get install --no-install-recommendslist of each variant. No new layer, no newENV *_VERSIONpin — likegit,jq,ripgrepandtmux, nano comes from the distro repos rather than a pinned download.Makefile:nano --versionadded to_testcase-common, so every variant checks it viamake test DOCKER_VARIANT=<variant>.Notes
Verified that
nanois in the Ubuntu repos and thatnano --versionis a valid invocation. The images themselves were not built here — CI covers that.The branch was restarted from
masterafter #16 merged, so this PR contains only the nano commit.🤖 Generated with Claude Code
https://claude.ai/code/session_017jPxeenJt19PJStMMeb1Em
Generated by Claude Code