-
Notifications
You must be signed in to change notification settings - Fork 629
Pull Request for docker/multi-container to compared and implemented the both #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 10 commits
3bf1410
b6a2bdd
1fb179f
4561baf
6a0e441
cdb900d
7efce3d
63182c0
6a5cd9f
39257a4
00f0a45
59c1d91
6c28f0d
49715d4
f9a82f2
0decdfc
73b60af
aff63f2
5bb96b9
0f4ebe1
4b94ac9
230ca91
e81aea0
e8c0cd0
ca81aac
caa4512
fd42c1e
f936d1a
1d66e3d
9f02363
ceee602
2e9e711
10e194b
1daab53
02b63ce
719d6cc
c656ad7
51936e9
df7d469
6c9ee8e
358335a
a5c1834
a434a68
46b652c
69c6da8
d713ccf
f4f82e0
a011d52
378c9b7
028e973
f01f7ab
be47549
649d387
8c10a18
5c0f60e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| name: NodeJS with Webpack | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ "main" ] | ||
| pull_request: | ||
| branches: [ "main" ] | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [18.x, 20.x, 22.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
|
|
||
| - name: Build | ||
| run: | | ||
| npm install | ||
| npx webpack | ||
|
Comment on lines
+1
to
+29
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| // Enhanced configuration: supports environment-based MongoDB URIs for flexibility and security | ||
| const mongoProdURI = process.env.MONGO_PROD_URI || 'mongodb://todo-database:27017/todoapp'; | ||
|
|
||
| module.exports = { | ||
| mongoProdURI: 'mongodb://todo-database:27017/todoapp', | ||
| mongoProdURI, | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The npm install command runs in the repository root, but package.json is located in the 'app/' subdirectory. This will fail because there's no package.json in the root. The workflow should change to the app directory before running npm install.