feat: support vLLM nightly builds via wheels.vllm.ai#735
Closed
doringeman wants to merge 1 commit intodocker:mainfrom
Closed
feat: support vLLM nightly builds via wheels.vllm.ai#735doringeman wants to merge 1 commit intodocker:mainfrom
doringeman wants to merge 1 commit intodocker:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for installing vLLM nightly builds from wheels.vllm.ai by adding a VLLM_COMMIT build argument. However, the VLLM_COMMIT build argument is handled unsafely in both the Makefile and the Dockerfile, leading to potential command injection and path traversal vulnerabilities. This could allow an attacker to execute arbitrary code on the build server, compromise the resulting Docker image, or cause pip to fetch packages from an unintended location. Strict validation for the VLLM_COMMIT argument and proper quoting in the Makefile are recommended.
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
c25e2a4 to
f8c69db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install vLLM from https://wheels.vllm.ai/{VLLM_VERSION}/{VLLM_CUDA_VERSION} instead of GitHub Releases, allowing nightly builds to be used via
make docker-run-vllm VLLM_VERSION=nightly(or pinned to a specific commit hash for reproducible builds).vLLM stable releases (0.16.x) do not yet support Qwen3.5 (#731) — support is available on the main branch ahead of 0.17.0. vLLM publishes pre-built wheels for every merged commit at wheels.vllm.ai, which this change allows us to use.
Usage
E.g.,
E.g., (intentionally the same commit as nightly)
E.g.,