Skip to content

fix(cli): drop cmd/cli tag prefix#697

Merged
doringeman merged 1 commit intodocker:mainfrom
doringeman:cli
Feb 19, 2026
Merged

fix(cli): drop cmd/cli tag prefix#697
doringeman merged 1 commit intodocker:mainfrom
doringeman:cli

Conversation

@doringeman
Copy link
Contributor

We stopped using the cmd/cli tag prefix for CLI releases with #682.

$ make install-cli
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C cmd/cli install
Building model-cli...
go build -ldflags="-s -w -X github.com/docker/model-runner/cmd/cli/desktop.Version=v1.0.24-12-g58bf78d0-dirty" -o model-cli .
Using existing binary model-cli
Linking model-cli to Docker CLI plugins directory...
Link created: /Users/dorin/.docker/cli-plugins/docker-model

$ docker model version
Docker Model Runner version v1.0.24-12-g58bf78d0-dirty
Docker Engine Kind: Docker Desktop

We stopped using the cmd/cli tag prefix for CLI releases with docker#682.

Signed-off-by: Dorin Geman <dorin.geman@docker.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @doringeman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the build process for the Docker Model Runner CLI to reflect a change in how release versions are tagged. It modifies the Makefile to ensure that the CLI's version string is correctly generated without an outdated prefix, streamlining the version reporting mechanism.

Highlights

  • Version Tagging: Updated the Makefile to remove the cmd/cli/ tag prefix from the version string generated during the build process, aligning with recent changes in release tagging strategy.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • cmd/cli/Makefile
    • Updated the go build command to use the new version tagging scheme.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Makefile for the CLI to align with the new version tagging strategy, removing the cmd/cli prefix from tag matching. The change simplifies the version string generation for development builds. I have one suggestion to make the tag matching pattern more robust.

@doringeman doringeman merged commit a1e9a79 into docker:main Feb 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants