Add remotes to createprofile #325
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the createprofile logic we were skipping any entries that did not have an image. This inadvertently skipped any remotes. Add a check for remotes.
Collaborator
There was a problem hiding this comment.
The local beads file shouldn't be versioned, right?
Contributor
Author
There was a problem hiding this comment.
I didn't mean to add it. removing it
Collaborator
There was a problem hiding this comment.
I've fixed this in #313 as well. Can you take a look at the change to createprofile.go there? I'm just putting the final touches on that PR right now.
cmrigney
approved these changes
Jan 6, 2026
| // Determine server type based on whether it has an image or remote endpoint | ||
| var serverType workingset.ServerType | ||
|
|
||
| if catalogServer.Image != "" { |
Contributor
There was a problem hiding this comment.
Just for reference, there is a Type property that will either be server, remote, or poci that could also be checked here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
In the createprofile logic we were skipping any entries that did not have an image. This inadvertently skipped any remotes.
This PR adds a check for remotes. If the server is either a remote or an image it will be added to a profile.
To reproduce the issue:
mcp-create-profileto save server and config to a profileRelated issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did