[wip] policy #319
Draft
[wip] policy #319
+648
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Howard <jacob.howard@docker.com>
- Rename ApplyPolicy to FilterByPolicy for clarity - Add policy check in mcp-add to block denied servers - Add policy check in mcp-exec to prevent tool invocation bypass - Filter dynamically added tools on tools/list_changed notification All policy checks use fail-open pattern: only deny when explicitly blocked AND no error occurred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
ApplyPolicy→FilterByPolicyfor clarityAdditional enforcement points:
tools/list_changed- Filter tools when servers dynamically update their tool listmcp-execbypass - Add policy check before direct tool invocation viamcp-execmcp-addserver-level gap - Block adding servers that are denied by policy