Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
❌ PR Review Failed — The review agent encountered an error and could not complete the review. View logs. |
|
/review |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
Assessment: 🟡 NEEDS ATTENTION
This PR addresses 4 GitHub issues with updates to billing and SSO documentation. The changes are generally good, with accurate information and appropriate scope. One medium-severity clarity issue was found in the SSO FAQ that should be addressed.
Findings
1 issue found (1 medium)
- ✅ No critical issues (vendored content, missing redirects)
- ✅ Content accuracy is good
⚠️ One clarity issue with phrasing
| Docker recommends that you contact your identity provider to retrieve a new X.509 certificate, then update the certificate in the [SSO configuration settings](/manuals/enterprise/security/single-sign-on/manage.md#manage-sso-connections) in the Docker Admin Console. | ||
|
|
||
| - If your organization doesn't enforce SSO, your users can log in with their username and password credentials. | ||
| - If your organization enforces SSO and credentials won't work, then Docker recommends you [contact us](https://app.docker.com/support/contact) for additional support. |
There was a problem hiding this comment.
ISSUE: Awkward phrasing creates confusing logic
The phrase "If your organization enforces SSO and credentials won't work" is redundant and confusing. When SSO is enforced, credentials won't work by definition—this is the expected behavior, not a separate condition.
Suggested fix:
Break this into clearer statements:
- If your organization enforces SSO, username and password credentials won't work. Contact [Docker support](https://app.docker.com/support/contact) for additional help.Or use parenthetical explanation:
- If your organization enforces SSO (where credentials won't work), contact [Docker support](https://app.docker.com/support/contact) for additional help.Style note: Per STYLE.md, "Docker recommends you" is meta-commentary that adds little value. Be more direct: "Contact Docker support" instead of "Docker recommends you contact us."
2 participants
PR to address 4 GitHub issues assigned to my docs areas.