docker-engine: add nri_no_wasm build tag#1286
docker-engine: add nri_no_wasm build tag#1286austinvazquez wants to merge 1 commit intodocker:masterfrom
Conversation
|
Looks like you only updated the RPM dockerfiles, not the DEB ones https://github.com/docker/docker-ce-packaging/tree/master/deb Probably we need changes in either moby, or the static scripts used here (or both) |
|
Edit: oop, UI just refreshed when I commented. I'll look into it @thaJeztah 👍🏼 |
|
Plucky looks like an issue on their side (I went looking if it was already EOL, but looks like it's still supported til January) Either that, or perhaps some bad mirror state |
|
I'm leaning towards bad mirror bc I noticed arm is fine; only x86 is not happy. 😅 |
This change adds the `nri_no_wasm` build tag for docker engine builds. Reference: https://github.com/containerd/nri/blob/1078130fa016884b4c03880d9d587e6691a67d98/README.md#webassembly-support Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
austinvazquez
force-pushed
the
add-nri-no-wasm-for-de
branch
from
04c6614 to
7cef22b
Compare
|
Actually, we don't need to do it on the packaging repo side if we just disable it in the moby build script itself. |
|
Closing in favor of moby/moby#51772 |
3 participants
- What I did
This change adds the
nri_no_wasmbuild tag for docker engine builds. Reference: https://github.com/containerd/nri/blob/1078130fa016884b4c03880d9d587e6691a67d98/README.md#webassembly-support- Description for the changelog