feat(leantui): let embedders override the welcome banner#3610
Open
EronWright wants to merge 1 commit into
Open
feat(leantui): let embedders override the welcome banner#3610EronWright wants to merge 1 commit into
EronWright wants to merge 1 commit into
Conversation
The lean TUI's welcome banner was hardcoded ("docker agent") and ignored
Config.AppName, so embedders couldn't brand it. Add an optional
Config.Banner []string; commitWelcome falls back to the built-in
bannerLines when unset, so existing behavior is unchanged.
aheritier
added
area/tui
rumpl
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The lean TUI's welcome banner is hardcoded ASCII art ("docker agent")
and is not derived from
Config.AppName(which is only used as a textlabel elsewhere). Embedders that reuse the lean TUI therefore can't brand
the welcome screen with their own art.
This adds an optional
Config.Banner []string:bannerLinesart is used, soexisting behavior is unchanged.
commitWelcomerenders the provided lines in place of thebuilt-in art, reusing the same top/left padding, accent styling, and
help footer — so a custom banner looks native and the embedder only
has to supply the raw art.
It's a
[]string(pre-split lines) to match the existingbannerLinesshape and the per-line render loop; each line ideally fits within ~56
columns like the built-in art.
Tests
Adds
TestCommitWelcomeUsesConfiguredBanner, asserting a configuredbanner renders at the correct padded offset and replaces (does not
append to) the built-in art.