fix(runtime): make startupInfoEmitted atomic (#3593)#3608
Draft
aheritier wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3593 —
startupInfoEmittedwas a plainboolwith a check-then-setpattern, raced by
App.Startemitting startup info from a spawned goroutine(
pkg/app/app.go) whilereEmitStartupInforesets and re-emits from another(e.g. on a new session). Result: a data race plus duplicate or missed startup
info.
This is finding A4 from the internal codebase audit.
What changed
startupInfoEmittedis nowatomic.Bool.EmitStartupInfousesCompareAndSwap(false, true)so only the CAS winner emits within an epoch;ResetStartupInfousesStore(false)to open a new epoch allowing exactlyone subsequent re-emit.
Testing
pkg/runtime/startupinfo_race_test.go— concurrent start + re-emit, plus asingle-emission invariant. Verified to fail (data race + duplicate/missed
emission) against the pre-fix plain-
boolcode and pass now.task dev+go test -race -count=2 ./pkg/runtime/... ./pkg/app/...: green(validated in isolation).
Merge note
Minor overlap with #3587 (A6) on the
LocalRuntimestruct: A6 changesalignment / adjacent fields while keeping the old
bool. Reconciliation keepsA6's fields and this branch's
atomic.Bool. Not a blocker in isolation.Opened as a draft pending final maintainer review.