feat: add --profiles-only flag to stop and restart commands - #14000
Open
glours wants to merge 1 commit into
Open
feat: add --profiles-only flag to stop and restart commands#14000glours wants to merge 1 commit into
glours wants to merge 1 commit into
Conversation
Acting on only the services of a profile currently requires naming each service explicitly, as `--profile x stop` or `--profile x restart` also target services without profiles (docker#13993, previously docker#12648). The new flag restricts both commands to services enabled by a profile: the active profiles when some are set via --profile or COMPOSE_PROFILES, otherwise services from all profiles. Services without profiles are never affected. `down` intentionally keeps its whole-application semantics. Signed-off-by: Guillaume Lours <glours@users.noreply.github.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Acting on only the services of a profile currently requires naming each service explicitly, as
--profile x stopor--profile x restartalso target services without profiles (#13993, previously #12648).The new flag restricts both commands to services enabled by a profile: the active profiles when some are set via --profile or COMPOSE_PROFILES, otherwise services from all profiles. Services without profiles are never affected.
downintentionally keeps its whole-application semantics.Related issue
fixes #13993
(not mandatory) A picture of a cute animal, if possible in relation to what you did
