Add --annotation flag to docker compose publish#13852
Open
Mohataseem89 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Mohataseem Khan <mohataseem89@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #13739
Adds a repeatable
--annotation key=valueflag to docker compose publish allowing users to attach custom OCI annotations to the published manifest (and to the image index as well, when --app is used in addition to the existing default annotations likeorg.opencontainers.image.createdadded a unit test (
cmd/compose/publish_test.go) covering valid input, malformed input missing =, and an empty slice. ranmake build, make test, and go vet ./...locally all passing. docs regenerated viamake docs