Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new production-oriented docker compose deploy command and corresponding backend/API plumbing to build/push images and apply a Compose project onto a Docker server, with optional health-check-based waiting.
Changes:
- Introduces a new CLI command:
docker compose deploywith flags for build/push, orphans removal, and wait/timeout. - Extends the public
pkg/apiCompose interface withDeploy(...)and addsDeployOptions. - Implements
composeService.Deployby chainingBuild, optionalPush, andUp.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
pkg/compose/deploy.go |
Backend implementation of Deploy that orchestrates Build/Push/Up. |
pkg/api/api.go |
Adds Deploy to the public API and defines DeployOptions. |
cmd/compose/deploy.go |
New CLI command, flags, and wiring to backend Deploy. |
cmd/compose/compose.go |
Registers the new deploy subcommand in the root command. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Implements a production-oriented deploy command that builds, pushes, and applies a Compose project to a Docker server with force-recreate semantics and optional health-check-based wait for zero-downtime deployments. Signed-off-by: Eric Curtin <eric.curtin@docker.com>
0ef488c to
2f139b5
Compare
|
I'm not convinced this requires a dedicated command. IMHO many user would have a distinct vision about what a "production" deployment looks like, and as such would just write their own minimal script to automate this compose command sequence |
|
I would also suggest you open a feature request issue / talk to maintainers on slack when you have such a proposal, so we can align before you volunteer to implement the feature |
Implements a production-oriented deploy command that builds, pushes, and applies a Compose project to a Docker server with force-recreate semantics and optional health-check-based wait for zero-downtime deployments.