Conversation
whalelines
left a comment
whalelines
left a comment
There was a problem hiding this comment.
The latest docker-library PR, docker-library/official-images#16141, appears to be adding azul-zulu, so the path of these files should be updated from zulu/ to azul-zulu/.
azul-zulu/content.md
Outdated
| * Azul Zulu 17 based on Ubuntu: | ||
| ``` | ||
| docker run -it --rm azul/azul-zulu:17 java -version | ||
| ``` | ||
| * Azul Zulu 17 based on Debian: | ||
| ``` | ||
| docker run -it --rm azul/azul-zulu-debian:17 java -version | ||
| ``` | ||
| * Azul Zulu 17 based on CentOS: | ||
| ``` | ||
| docker run -it --rm azul/azul-zulu-centos:17 java -version | ||
| ``` | ||
| * Azul Zulu 17 based on Alpine: | ||
| ``` | ||
| docker run -it --rm azul/azul-zulu-alpine:17 java -version | ||
| ``` | ||
| * Azul Zulu 17 based on Distroless: | ||
| ``` | ||
| docker run -it --rm azul/azul-zulu-distroless:17 --version | ||
| ``` |
There was a problem hiding this comment.
These commands still all reference non-existent images. The PR to create a new DOI, docker-library/official-images#14593 , would create the images in the repository azul-zulu-openjdk, so the images would look something like azul-zulu-openjdk:17-ubuntu, i.e., there is no namespace and the base image type appears in the tag, not the repository.
There was a problem hiding this comment.
correct @whalelines, I modified this pull request to align with DOI merge request docker-library/official-images#16141.
But this means both pull requests should get approved and published together?
FYI as mentioned in the last comment in docker-library/official-images#14593, the correct merge request for DOI Azul Zulu is docker-library/official-images#16141
|
great, thank you, and can you also merge it, @LaurentGoderre? |
|
Your continued patience is appreciated. |
|
This documentation proposal has been updated to align with the pull request |
yosifkit
left a comment
yosifkit
left a comment
There was a problem hiding this comment.
Just a couple comments/questions.
azul-zulu/license.md
Outdated
| @@ -0,0 +1 @@ | |||
| View [license information](https://github.com/AzulSystems/azul-zulu-images/blob/master/LICENSE.txt) for the software contained in this image. | |||
There was a problem hiding this comment.
This link doesn't work since there isn't a License.txt in the AzulSystems/azul-zulu-images repo. Can you add one there to make it clear what license applies to the Dockefiles themselves?
Perhaps you may also want a link here to the OpenJDK License (https://openjdk.org/legal/gplv2+ce.html)?
There was a problem hiding this comment.
Thanks for reporting. I'm checking which license we need to add to the Azul repo.
Proposal to add the Azul Zulu images as official images.
Relates to docker-library/official-images#14593Relates to docker-library/official-images#16141