Skip to content

First code submission for MVC Pipeline#6749

Open
donker wants to merge 248 commits intofeature/mvc-pipelinefrom
feature/mvc-pipeline-old
Open

First code submission for MVC Pipeline#6749
donker wants to merge 248 commits intofeature/mvc-pipelinefrom
feature/mvc-pipeline-old

Conversation

@donker
Copy link
Copy Markdown
Contributor

@donker donker commented Oct 3, 2025

Core Purpose

Introduces a new ASP.NET MVC-based rendering pipeline as an alternative to the traditional WebForms pipeline, allowing DNN to modernize its architecture while maintaining backward compatibility.

Key Features

Dual Pipeline Architecture:

  • Traditional WebForms pipeline continues through /default.aspx
  • New MVC pipeline routes through /DesktopModules/Default/Page/{tabId}/{locale}

Video showcase the general usage

Module Support:

More info about MVC Module Control Implementation
Razor+ Module Development Guide

  • HTML module converted to MVC
  • Sample modules demonstrating Razor+, MVC and SPA patterns

How to compile Samples

Configuration:

  • Pipeline selection at portal and page level
  • Settings UI integrated into Site and Page Settings
  • URL rewriter modifications to route based on pipeline settings

More info about MVC pipeline (routing / settings)

New MVC Pipeline Projects

DotNetNuke.Web.MvcPipeline.csproj - New core MVC pipeline library

  • Skins : Html Helpers (replacement for skin objects)
  • Containers : Html Helpers (replacement for skin objects for containers)
  • ModelFactories : construction of the Page Model (Model of the DefaultController)
  • ModuleControl : Module Control infrastructure
  • Utils : MvcViewEngine (Replacement for RazorEngine based on MVC 5 and can only be used inside HttpContext)
  • UI/Utilities : MvcClientAPI (replacement for ClientAPI for mvc)

Razor Module Sample

  • Razor-based module sample project

NewDDRMenu

  • Fork of DDRMenu for MVC navigation support (WIP)

Core Platform Projects

DotNetNuke.Library

  • Added Site and Page pipeline settings
  • Added Module Control settings
  • URL rewriter changes to route based on pipeline settings
  • Update SPA (Html5) to use new CDF

DotNetNuke.Abstractions

  • Added PagePipeline property to IPortalSettings

DotNetNuke.Web.Mvc

  • Integration with new MVC pipeline
  • Make actual DNN MVC modules run on the MVC Pipeline

HTML

  • Add support for MVC Pipeline rendering
  • Add MVC views and controllers
  • This is implemented as true MVC (with form tags) using AJAX

Dnn.PersonaBar.UI

UI for pipeline settings in Site and Page Settings

DNNConnect.CKE

  • HTML helper additions for CKEditor in MVC context

Skins/Aperture

  • Added mvc suport to the skin (Razor files)

Skin conversion guide

Website

  • MVC Razor Layout
  • MVC Default skin
  • mvc.js minimal stuff needed for dnn to work
  • Terms and privacy pages (razor files)
  • DefaultController
  • ModuleActions Controller

AdminExperiance

  • settings ui for new settings
  • mvc controls for persona and edit bar

This PR is a first submission of the work of the MVC Pipeline team to bring the main project up to date with what has been developed in a forked repo.

Documentation

MVC Module Control Implementation
MVC pipeline (routing / settings)
Razor Module Development Guide
How to compile Samples

DNN MVC Pipeline - Developer User Guide

donker and others added 30 commits March 20, 2025 11:36
client dependecy for mvc (because it not exist in nuget)
sachatrauwaen and others added 21 commits January 29, 2026 23:18
Updated user guide for MVC pipeline with corrections and clarifications.
# Conflicts:
#	DNN Platform/DotNetNuke.Web.Mvc/Framework/Controllers/DnnController.cs
#	DNN Platform/DotNetNuke.Web.Mvc/Framework/Modules/ResultCapturingActionInvoker.cs
#	DNN Platform/DotNetNuke.Web.Mvc/Routing/MvcRoutingManager.cs
#	DNN Platform/Library/Entities/Portals/PortalSettings.cs
#	DNN Platform/Library/Entities/Portals/PortalSettingsController.cs
#	DNN Platform/Library/Entities/Urls/AdvancedUrlRewriter.cs
#	DNN Platform/Library/UI/Modules/Html5/Html5HostControl.cs
#	DNN Platform/Library/UI/Modules/Html5/Html5ModuleControlFactory.cs
#	DNN Platform/Modules/DDRMenu/Common/DNNContext.cs
#	DNN Platform/Modules/DDRMenu/Localisation/Localiser.cs
#	DNN Platform/Modules/DDRMenu/MenuBase.cs
#	DNN Platform/Modules/DDRMenu/TemplateEngine/TemplateDefinition.cs
#	DNN Platform/Modules/HTML/Components/HtmlTextController.cs
#	DNN Platform/Providers/HtmlEditorProviders/DNNConnect.CKE/Web/EditorControl.cs
#	Dnn.AdminExperience/Dnn.PersonaBar.Extensions/admin/personaBar/Dnn.SiteSettings/App_LocalResources/SiteSettings.resx
@sachatrauwaen
Copy link
Copy Markdown
Contributor

I’d like to check the status of this PR. There hasn’t been any review activity for several months—are there any issues or blockers? How can I help move things forward?

It might also be worth bringing this up during a TAG meeting ?

I completely understand that reviewing this PR is a significant effort. At the same time, on the otherhand inoticing quite a few major changes being made elsewhere, which also require substantial merge work on my side.

I believe it’s generally more efficient to process PRs in order (except for bug fixes, of course). Otherwise, each new PR tends to create additional merge overhead for those still pending.

@thienvc
Copy link
Copy Markdown
Contributor

thienvc commented Apr 4, 2026

I’d like to check the status of this PR. There hasn’t been any review activity for several months—are there any issues or blockers? How can I help move things forward?

It might also be worth bringing this up during a TAG meeting ?

I completely understand that reviewing this PR is a significant effort. At the same time, on the otherhand inoticing quite a few major changes being made elsewhere, which also require substantial merge work on my side.

I believe it’s generally more efficient to process PRs in order (except for bug fixes, of course). Otherwise, each new PR tends to create additional merge overhead for those still pending.

I wish this PR was a custom package that could be installed and uninstalled like a plugin.
If that were the case, I think it wouldn't affect the official version.


if (isAuthenticated)
{
csp.FrameSource.AddHost("https://dnndocs.com").AddHost("https://docs.dnncommunity.org");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be a global approval, this will result in some really funny security responses most likely

value = requestBase.Headers[key];
}

if (requestBase.Form[key] != null)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to review/discuss the possible risks wit htis change, by accpeting the value from the form in any situation , as I believe this might expose a different method of manipulation that could have unintended consequences.

// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information
namespace DotNetNuke.Web.MvcPipeline.Commons
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entire implementation already exists within the solution at DotNetNuke.Web.Mvc.Common

Should this be a move? Should the old file be marked as Obsolete?

// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information

namespace DotNetNuke.Web.MvcPipeline.Commons
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To match other naming conventions if needed this namespace/folder should be Common not Commons

/// <summary>
/// Base controller for DNN MVC page controllers, exposing common services and portal context.
/// </summary>
public abstract class DnnPageController : Controller, IMvcController
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar question here for the fate of the existing IDNNController and related items, as I can see a lot of confusion without some level of guidance being provided at a programming perspective with different behaviors and purposes. For example this ONLY provides PortalSettings the legacy one provides much more rich context (User, etc)

/// Builds an edit URL for the current module instance.
/// </summary>
/// <returns>The edit URL.</returns>
public string EditUrl()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I echo @valadas comments on this duplication of exploding items that are already there, the long-term maintenance of this, as we have seen with other changes, is not exactly "fun". I would prefer exposing the ModuleContext and leaving it at that personally

.Register();

/*
if (Host.CdnEnabled && !string.IsNullOrEmpty(jsl.ObjectName))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commented out code should be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

6 participants