Enable to pass database url directly for config#2
Open
paulsohn wants to merge 2 commits intodmcaulay:masterfrom
Open
Enable to pass database url directly for config#2paulsohn wants to merge 2 commits intodmcaulay:masterfrom
paulsohn wants to merge 2 commits intodmcaulay:masterfrom
Conversation
added 2 commits
September 30, 2016 14:18
Someone would like this.
added more description for `config` object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Someone like me wouldn't like the way
.setupexamines and make the query string. I got a full url string that have been used couple of times in my project(e.g. connect-mongodb-session) and I don't want to have a separated setting object.Or, you could split the setup method to have a helper method that simply converts object into url string for convenience.