Skip to content

refactor(view): guard null placeholder instead of waiting on open#290

Merged
dlyongemallo merged 1 commit into
mainfrom
289-performance_regression
Jul 10, 2026
Merged

refactor(view): guard null placeholder instead of waiting on open#290
dlyongemallo merged 1 commit into
mainfrom
289-performance_regression

Conversation

@dlyongemallo

@dlyongemallo dlyongemallo commented Jul 9, 2026

Copy link
Copy Markdown
Owner

Fixes #289 (and should preserve the fix for #262).

Shadow `do`/`dp`/`[1-3]do` with `<Nop>` on `File.NULL_FILE` so typeahead
lands safely before `View:open` returns. Drops the `vim.wait` race guard
and its `_mark_ready_when_settled` scaffolding.
@dlyongemallo dlyongemallo force-pushed the 289-performance_regression branch from ce73ecb to b47cfce Compare July 10, 2026 06:39
@dlyongemallo dlyongemallo changed the title fix(view): drop cur_entry from View:open's race guard refactor(view): guard null placeholder instead of waiting on open Jul 10, 2026
@dlyongemallo dlyongemallo merged commit 3bb7a69 into main Jul 10, 2026
8 checks passed
@dlyongemallo dlyongemallo deleted the 289-performance_regression branch July 10, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

performance regression on :DiffviewOpen

1 participant