Fix Issue 10549 - allow clamp with int literals on smaller integrals - #11074
Open
niy-ati wants to merge 1 commit into
Open
Fix Issue 10549 - allow clamp with int literals on smaller integrals#11074niy-ati wants to merge 1 commit into
niy-ati wants to merge 1 commit into
Conversation
Integer literals are typed as int, so clamp(ubyte(4), 1, 5) failed the is(T2 : T1) check after clamp began returning typeof(val). Allow int bounds when the value type is a smaller integral, cast bounds on return, and assert that narrowed bounds are representable.
0xEAB
added
Severity:Bug Fix
Review:AI Generated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clamp(ubyte(4), 1, 5)(and other smaller-than-intvalue types withintliteral bounds) after Fix Issue 22414 - clamp(a, b, c) should always return typeof(a) #8293 requiredclampto returntypeof(val).longwith anintvalue (same policy as Fix Issue 22414 - clamp(a, b, c) should always return typeof(a) #8293).T1on return and assert that narrowed bounds are representable; fix mangledclampddoc.Fixes #10549
Test plan
uint.maxcases still covered by existing unittestsclamp(0, long.max, long.max)still rejected at compile time