druntime integration tests: Fix musl detection with dash shell#21779
druntime integration tests: Fix musl detection with dash shell#21779kinke wants to merge 3 commits intodlang:masterfrom
Conversation
As dash apparently doesn't understand the `&>` redirection, see ldc-developers/ldc#4970 (comment), causing IS_MUSL to be wrongly set on non-musl distros.
|
Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#21779" |
Based on dlang/dmd#21779. For LDC, always define IS_MUSL externally, not just to `1` for musl targets.
|
Note #21741 I think it's better to carry this musl detection in a common file like |
|
I'd have extracted it if a third file needs it. ;) - Unfortunately we cannot put it in existing |
|
Yeah, I got it wrong the first time by changing |
c2d6bda to
cc28b26
Compare
Oh damn, overlooked that at first because I thought you'd link to some post in the LDC repo. 🤦 |
|
Closing in favor of #21741. |
As dash apparently doesn't understand the
&>redirection, see ldc-developers/ldc#4970 (comment), causing IS_MUSL to be wrongly set on non-musl distros.