Skip to content

Conversation

@Anujpandey12345
Copy link

Fixes #2435

Adds a stable django.org URL under /foundation/ that redirects to the
Individual Membership nomination form. This avoids hard-coding a
third-party form URL and allows the underlying provider to change
without breaking links.

Copy link
Member

@pauloxnet pauloxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ulgens ulgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good functionally, but I'd recommend adding a test, and if you have the time, moving the URL to a central place (e.g settings file)

Also, we don't use django.org domain for the website.

You can check https://github.com/django/djangoproject.com?tab=readme-ov-file#git-hooks to install git hooks locally.

@Anujpandey12345
Copy link
Author

@ulgens Thanks for the review and suggestions!
I kept the PR scope minimal for now, but I’m happy to add a test or refactor the URL into settings if you think it’s required for this change.

@ulgens
Copy link
Member

ulgens commented Jan 8, 2026

Not a hard requirement but I think a test could be nice. I'm okay if others are okay with handling it later.

@pauloxnet
Copy link
Member

I like the idea to add a unit test that maybe check that a redirect is in place not specifically the URL of the redirect

@Anujpandey12345
Copy link
Author

@ulgens @pauloxnet Thanks for the clarification!
That makes sense — I’ll add a small unit test that simply verifies the redirect is in place (without asserting the specific target URL), and push an update shortly.

@Anujpandey12345
Copy link
Author

@ulgens @pauloxnet I’ve added a small unit test that verifies the redirect is in place without asserting the specific target URL. Thanks for the suggestion!

@pauloxnet
Copy link
Member

@ulgens @pauloxnet I’ve added a small unit test that verifies the redirect is in place without asserting the specific target URL. Thanks for the suggestion!

Thanks. Can you fix the linting/formatting error?
Maybe it' a good idea to install and run locally pre-commit/prek on branch.

@Anujpandey12345
Copy link
Author

@pauloxnet Thanks! I ran pre-commit locally and pushed the linting/formatting fixes.

@pauloxnet
Copy link
Member

@pauloxnet Thanks! I ran pre-commit locally and pushed the linting/formatting fixes.

I think there's still a formatting issue (see the pre-commit.ci check)

djangoproject/urls/www.py:146:91: E501 line too long (118 > 90 characters)

I think in this case you have to manually split the URL text manually or use the short form of the same URL

https://forms.gle/xKaZQqYswbMu2K5q6

@Anujpandey12345
Copy link
Author

@pauloxnet I’ve run pre-commit locally; black reformatted the file and I’ve pushed the update. Thanks!

Copy link
Member

@pauloxnet pauloxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulgens ulgens self-requested a review January 9, 2026 07:38
@ulgens
Copy link
Member

ulgens commented Jan 9, 2026

Gave my approval, but I will recommend a squash merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a django.org redirect URL for Individual Membership nomination form

3 participants