Redirect /about to /foundation #2429
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Several notes:
- Please install git hooks as described in https://github.com/django/djangoproject.com?tab=readme-ov-file#git-hooks and apply the hooks on your commit.
- We can use
reverse()for getting the foundations path URL, instead of hardcoding it. - Please add tests to validate the new behaviour.
|
Thanks for the review! I’ve updated the redirect to use pattern_name (via reverse()) instead of a hardcoded URL and added tests to validate the new behavior. I’ll also make sure to have the git hooks installed locally for future commits. |
| "about/", | ||
| RedirectView.as_view( | ||
| pattern_name="members:developer-members", | ||
| permanent=True, |
There was a problem hiding this comment.
Not sure about permanent=True. @django/django-website Any thoughts?
There was a problem hiding this comment.
Good question. I added permanent=True assuming this is intended as a long-term redirect since /about/ shouldn’t be served anymore and should consistently point to /foundation/.
That said, I’m happy to remove it or switch to a temporary redirect if that’s preferred here — happy to follow the project’s convention.
|
Thanks again for the review! I believe I’ve addressed all the feedback and wanted to check if anything else is needed from my side. Happy to adjust permanent=True or anything else based on the project’s preference. |
2 participants
Adds a RedirectView to redirect
/aboutto/foundationinstead of returning a 404.Fixes #2428