Adding "Using an Embedded Model as an abstract base class" to the docs.#92
Open
Nolhian wants to merge 1 commit intodjango-nonrel:masterfrom
Open
Adding "Using an Embedded Model as an abstract base class" to the docs.#92Nolhian wants to merge 1 commit intodjango-nonrel:masterfrom
Nolhian wants to merge 1 commit intodjango-nonrel:masterfrom
Conversation
Contributor
|
Thanks for the addition. The issue with the class not being a string is a bug in djangotoolbox though and should be fixed there. |
Contributor
|
We should probably add the "you can use abstract models" thing to the docs once the bug is fixed. |
Member
|
I don't see why we should keep this open if it is a djangotoolbox issue. We can just close it and add the doc string once the bug is fixed. |
Contributor
|
Yeah we need to remember to add it to the docs somehow :) You can also open another bug somewhere. Just something to remember it later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In docs / source / topics / embedded-models.rst