refactor: NETA for all#2450
Merged
Merged
Conversation
trisyoungs
force-pushed
the
dissolve2/atom-base-class
branch
from
9b4ec14 to
9837554
Compare
Contributor
There was a problem hiding this comment.
Interestingly, it appears to me that we have boiled StructureAtom down to the point that it's not clear that it's necessary for it to be a type of its own! I did wonder if there is a case to be made for simply replacing instances of StructureAtom with instances of Atom<Bond<Atom>> but then the inner Atom will also need a template! That leads me to the conclusion that this non-templated type is in fact very necessary for solving that recursion, but it does seem like there should be a slightly more "efficient" way of doing things here.
trisyoungs
force-pushed
the
dissolve2/atom-base-class
branch
2 times, most recently
from
7f85b31 to
4919e79
Compare
trisyoungs
force-pushed
the
dissolve2/neta-for-all
branch
from
719530d to
7d40b09
Compare
RobBuchananCompPhys
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes the long journey of immutable species, structure, and generic NETA usage. The dependence on
SpeciesAtomis removed from the NETA classes and replaced byBaseAtom.