feat: Refactor BraggNode test to get MgO from CIF file#2344
Merged
RobBuchananCompPhys merged 4 commits intodevelop2from Apr 10, 2026
Merged
feat: Refactor BraggNode test to get MgO from CIF file#2344RobBuchananCompPhys merged 4 commits intodevelop2from
RobBuchananCompPhys merged 4 commits intodevelop2from
Conversation
trisyoungs
requested changes
Apr 8, 2026
Member
trisyoungs
left a comment
trisyoungs
left a comment
There was a problem hiding this comment.
Looks good - tested and working! The actual unit cell is basically the same as from the previous old input file, so no need to rerun the EPSR tests as it turns out. There are some test data files to be removed (the whole dissolve2/bragg directory) and the PR itself can now be rebased onto develop2 and the tests themselves refactored a little to use the new graph creation functions.
RobBuchananCompPhys
force-pushed
the
dissolve2/bragg-mgo-from-cif
branch
from
d8da136 to
752b6c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.