Skip to content

fix scrolling behind full-screen #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
disnet merged 1 commit into from
Mar 19, 2026
Merged

fix scrolling behind full-screen #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions frontend/src/lib/components/feed/SavedReader.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,14 +218,27 @@
}
}

// Register keydown on document capture phase so the reader intercepts keys
// before the global keyboard store (which listens on window bubble phase).
// This prevents duplicate tag menus and other shortcut conflicts.
// Lock body scroll and prevent touch events from bubbling to PullToRefresh
// while the reader overlay is open.
function stopTouchPropagation(e: TouchEvent) {
e.stopPropagation();
}

onMount(() => {
document.body.style.overflow = 'hidden';
document.addEventListener('keydown', handleKeydown, true);
// The reader is a DOM child of PullToRefresh, so touch events bubble up
// and trigger pull-to-refresh even though the reader is a fixed overlay.
overlayEl?.addEventListener('touchstart', stopTouchPropagation, { passive: true });
overlayEl?.addEventListener('touchmove', stopTouchPropagation, { passive: true });
overlayEl?.addEventListener('touchend', stopTouchPropagation, { passive: true });
});
onDestroy(() => {
document.body.style.overflow = '';
document.removeEventListener('keydown', handleKeydown, true);
overlayEl?.removeEventListener('touchstart', stopTouchPropagation);
overlayEl?.removeEventListener('touchmove', stopTouchPropagation);
overlayEl?.removeEventListener('touchend', stopTouchPropagation);
});

// Paragraph tracking for read progress
Expand Down
Loading