Emit disabledCommandRun when running a disabled command#378
Emit disabledCommandRun when running a disabled command#378cocoliliace wants to merge 2 commits intodiscordjs:masterfrom cocoliliace:master
disabledCommandRun when running a disabled command#378Conversation
|
I noticed that disabled commands are checked in |
|
The idea behind a command being disabled is to prevent any additional processing for it, so nothing in the command's code is run at all. Off the top of my head, moving the handling for this to CommandMessage#run would mean that it occurs after parsing arguments and such. |
|
It looks like the conditions are checked at the beginning of CommandMessage#run, right before parsing the arguments, so I think CommandMessage#run would still be able to return early upon detecting the disabled command. |
Resolved #336