Skip to content

fix(api): reject invalid install skill ids - #137

Merged
dirtybits merged 1 commit into
mainfrom
fix/reject-invalid-install-id
Aug 4, 2026
Merged

fix(api): reject invalid install skill ids#137
dirtybits merged 1 commit into
mainfrom
fix/reject-invalid-install-id

Conversation

@dirtybits

Copy link
Copy Markdown
Owner

Summary

  • validate non-chain install route IDs as UUIDs before database initialization or SQL UUID casting
  • return the existing 404 {"error":"Skill not found"} contract for malformed repo-skill IDs
  • update install fixtures to use valid UUIDs and add a regression proving malformed IDs perform no database work

Test plan

  • npm test --workspace @agentvouch/web -- --maxWorkers=1 --no-fileParallelism __tests__/api/skills-install.test.ts
  • npm run format:check
  • npm run lint --workspace @agentvouch/web
  • npm run typecheck --workspace @agentvouch/web
  • npm test --workspace @agentvouch/web -- --maxWorkers=1 --no-fileParallelism
  • npm exec --workspace @agentvouch/web -- next build --webpack
  • git diff --check origin/main...HEAD

Not verified

  • No browser or live database smoke was run; this is a route-boundary validation change covered by unit tests.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@dirtybits
dirtybits merged commit 2cf448a into main Aug 4, 2026
3 checks passed
@dirtybits
dirtybits deleted the fix/reject-invalid-install-id branch August 4, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant