Skip to content

refactor(web): remove dead Base approval branch - #136

Open
dirtybits wants to merge 1 commit into
mainfrom
fix/remove-dead-base-approval-branch
Open

refactor(web): remove dead Base approval branch#136
dirtybits wants to merge 1 commit into
mainfrom
fix/remove-dead-base-approval-branch

Conversation

@dirtybits

Copy link
Copy Markdown
Owner

Summary

  • remove the unreachable sequentialApproval option and sequential approval branch from Base passkey USDC pull-writes
  • remove source-text assertions that only preserved the unreachable branch
  • retain the existing batched exact-approval plus contract-call behavior for every caller

Test plan

  • npm test --workspace @agentvouch/web -- --maxWorkers=1 --no-fileParallelism __tests__/lib/baseWallet.test.ts __tests__/lib/baseInjectedWallet.test.ts
  • npm run format:check
  • npm run lint
  • npm run typecheck
  • npm test
  • npm exec --workspace @agentvouch/web -- next build --webpack
  • git diff --check origin/main...HEAD

Not verified

  • No wallet/browser or live Base Sepolia transaction was run; this change only removes an unreachable internal path and does not alter the remaining batched write behavior.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant