Skip to content

implement TODO for <Triangle as Shape>::ccd_thickness - #9

Open
LoganDark wants to merge 2 commits into
dimforge:masterfrom
LoganDark:triangle_ccd_thickness
Open

implement TODO for <Triangle as Shape>::ccd_thickness#9
LoganDark wants to merge 2 commits into
dimforge:masterfrom
LoganDark:triangle_ccd_thickness

Conversation

@LoganDark

Copy link
Copy Markdown

This is just about the lamest change I could make to qualify as a "contributor", but I saw this TODO and thought it was something I could implement so here it is.

cargo test passes of course.

@LoganDark

LoganDark commented Feb 21, 2021

Copy link
Copy Markdown
Author

Quick note, there are a few different things that TODO comment could have meant, such as:

  1. the minimum distance an object aimed at some part of the triangle would have to travel in order to make it through the triangle (so 0.0, naturally, because of the points)
  2. the diameter of the largest circle that could fit inside the triangle, which is an ok approximation of number 1 without the points causing it to always be 0
  3. the minimum side length
  4. some other estimate? maybe the minimum distance from an edge to a point?

I just went with 3, but it's totally okay if something else was intended. Let me know and I might be able to do that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant