Change taskname from modulus-deploy to modulusDeploy#6
Open
rainabba wants to merge 2 commits intodigitaljohn:masterfrom
Open
Change taskname from modulus-deploy to modulusDeploy#6rainabba wants to merge 2 commits intodigitaljohn:masterfrom
rainabba wants to merge 2 commits intodigitaljohn:masterfrom
Conversation
…nt so it doesn't have to be quoted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm SO accustomed to just using proper JS object names, that I'd completely forgotten that I could qualify the names with quotes in this context (I only do that in JSON) and your README.md didn't (so it's using an invalid JS object name). So, here's a PR to update the project to use a valid js object name.
Thanks for the plugin!