Skip to content

Replace Sphinx docs with MkDocs Material#272

Open
anatoly-scherbakov wants to merge 26 commits into
masterfrom
docs/mkdocs-material
Open

Replace Sphinx docs with MkDocs Material#272
anatoly-scherbakov wants to merge 26 commits into
masterfrom
docs/mkdocs-material

Conversation

@anatoly-scherbakov
Copy link
Copy Markdown
Collaborator

@anatoly-scherbakov anatoly-scherbakov commented Jun 1, 2026

Fixes #259. Documentation at https://digitalbazaar.github.io/pyld/

Summary

  • replace the old Sphinx docs setup with MkDocs Material
  • add user-facing docs pages for installation, examples, document loaders, and manual API reference
  • add GitHub Pages deployment workflow and local make serve target

Validation

  • .venv/bin/mkdocs build --strict

Comment thread .github/workflows/docs.yaml Fixed
Comment thread .github/workflows/docs.yaml Fixed
Comment thread .github/workflows/docs.yaml Fixed
Comment thread .github/workflows/docs.yaml Fixed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

@mielvds mielvds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and also long overdue! I added some comments, nothing major. I can think of many things to add ofc., but I'll leave these for upcoming PR's. It would be nice to include this in the next release.

Comment thread Makefile
test:
pytest --cov=pyld

serve:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can serve the docs from make, I'd expect you can build them too (including installing the deps).

Comment thread docs/requirements.txt
@@ -1 +1,3 @@
sphinx-autobuild
-r ../requirements.txt
mkdocs-material
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd specify the version

Comment thread .gitignore
Comment thread docs/index.rst

PyLD is compatible with `Python`_ 2.5 and newer.

Credits
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a spot for this somewhere? Maybe it's time to add ourselves as current maintainers ;)

Comment thread docs/index.md
contexts, while keeping the document shape practical for web APIs, JavaScript,
and JSON document stores.

## Conformance
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While not really in scope, I'd align these updates with README.rst to not let things drift (this is long overdue as well, because it still talks about candidate recommendation). Maybe this is a good time to convert it to markdown as well?

Comment thread docs/index.md
@@ -0,0 +1,40 @@
# PyLD

PyLD is a Python implementation of the [JSON-LD][] processor API.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link is missing?

Comment thread docs/index.md

PyLD aims to conform with:

- [JSON-LD 1.1][json-ld-11]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, I'd like to see a table that links to the skipped tests

Comment thread docs/index.md
- [JSON-LD 1.1][json-ld-11]
- [JSON-LD 1.1 Processing Algorithms and API][json-ld-11-api]
- [JSON-LD 1.1 Framing][json-ld-11-framing]
- The JSON-LD Working Group [test suite][wg-test-suite]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also mention the normalization algorithms?

Comment thread docs/api-reference.md
@@ -0,0 +1,135 @@
# API Reference
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was generated using some tool?

Comment thread docs/document-loaders.md
@@ -0,0 +1,57 @@
# Document Loaders
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a similar document on ContextResolver? (see README)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More extensive documentation

3 participants