Switch to boost 1.88, using -std= c++14 #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Test on linux/x86 was also fine (build new libobjcryst and run pytest with pyobjcryst) |
Collaborator
Author
|
@sbillinge let me know if switching the conda-recipe to boost 1.88 and using c++ is ok with you (I don't know if it affects your other tools). This still needs to be tested under windows. |
Contributor
|
I don't think this affects us. Is there a build anywhere that we can build an env and test Duffpy.cmi it with this version? We may also want to look at this update ourselves for Duffy.srreal (sorry, fighting autocorrect... Not sure why it thinks I might mean Duffy) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix https://github.com/conda…-forge/libobjcryst-feedstock/pull/36 and allow using a more recent version of boost.
Only tested on macOS/arm64 so far.