Ensure no warning or errors when no extrapolation occurs#278
Merged
sbillinge merged 3 commits intodiffpy:mainfrom Dec 19, 2025
Merged
Ensure no warning or errors when no extrapolation occurs#278sbillinge merged 3 commits intodiffpy:mainfrom
sbillinge merged 3 commits intodiffpy:mainfrom
Conversation
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 24 24
Lines 1446 1480 +34
=======================================
+ Hits 1445 1479 +34
Misses 1 1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #255,
self.extrapolation_infowas not set as a class variable. As such, there are cases where the code seeks to reference this value when it is not defined, producing an error.For example, when a morph function without extrapolation warnings (e.g.
scale) is used with one with warnings (e.g.stretch) and the the one with warnings does not extrapolate (e.g.--scale=1 --stretch=0), this will produce an error.Tests are now added to cover this case in the future.
Please merge this asap. We may need to do a 0.3.1 release and scrap the 0.3.0 one on
conda-forgesince this error is not rare.