Only warn user about squeeze extrapolation after refinement#252
Merged
Sparks29032 merged 1 commit intodiffpy:mainfrom Sep 3, 2025
Merged
Only warn user about squeeze extrapolation after refinement#252Sparks29032 merged 1 commit intodiffpy:mainfrom
squeeze extrapolation after refinement#252Sparks29032 merged 1 commit intodiffpy:mainfrom
Conversation
Collaborator
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 23 23
Lines 1354 1355 +1
=======================================
+ Hits 1353 1354 +1
Misses 1 1
🚀 New features to boost your workflow:
|
Collaborator
Author
|
Changed the behavior to only give an error post-refinement. Previously, it was giving 100+ warnings in our tests, causing it to fail on macos-13. |
Sparks29032
added a commit
that referenced
this pull request
Sep 3, 2025
This reverts commit dce54cf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Update to #250, which would throw a warning each step of the refinement. We only want the user to see the warning afterward since only that quantity is useful.
Targets first check point of #243