Update numerical file comparisons in tests#231
Merged
sbillinge merged 4 commits intodiffpy:mainfrom Jul 9, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
=======================================
Coverage 99.07% 99.08%
=======================================
Files 21 21
Lines 1084 1087 +3
=======================================
+ Hits 1074 1077 +3
Misses 10 10
🚀 New features to boost your workflow:
|
sbillinge
reviewed
Jul 9, 2025
Contributor
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
looks good. Couple of small comments
tests/test_morphio.py
Outdated
| return False | ||
|
|
||
|
|
||
| def compare_numeric(file1, file2): |
Contributor
There was a problem hiding this comment.
this should probably have a name like are_same(file1, file2) since it returns True if they are the same and False if they are not. Something like that.
Collaborator
Author
There was a problem hiding this comment.
Changed to are_files_same
tests/test_morphio.py
Outdated
| generated = filter(ignore_path, gf) | ||
| target = filter(ignore_path, tf) | ||
| assert all(x == y for x, y in zip(generated, target)) | ||
| compare_numeric(generated, target) |
Contributor
There was a problem hiding this comment.
can we call the options expected and actual to make the test more intelligible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a shared function for numerical file comparisons.