skpkg: add configuration files for pre-commit, readthedocs, codecov#202
skpkg: add configuration files for pre-commit, readthedocs, codecov#202sbillinge merged 9 commits intodiffpy:migrationfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## migration #202 +/- ##
==========================================
Coverage 97.23% 97.23%
==========================================
Files 20 20
Lines 903 903
==========================================
Hits 878 878
Misses 25 25 🚀 New features to boost your workflow:
|
sbillinge
left a comment
There was a problem hiding this comment.
ok, this looks ok. I am not sure if we want the blocks with setup.cfg and the socioeconomic etc. that you added back in the last commit. Why did you add htat back? Was it not passing pre-commit without those? They are small things though, it doesn't really matter that much if they are there but not needed (just a bit of technical debt to carry forward to the future). But let me know why you added them back (as well as addressing the one inline issue).
This is marked as draft. Is there a reason for this? It is not finished on your side?
|
Sorry, I forgot to mark it as review yesterday. Regarding setup.cfg, I thought it seemed quite important for normal functionality, but I deleted it if it's not required. As for the socioeconomic block, it seems to be necessary to pass pre-commit. @sbillinge ready for review after addressing your inline comment |
|
OK, I can merge it like this. |
#201 needs to be closed first