docs: add temperature field to tutorial data#171
Closed
ycexiao wants to merge 3 commits intodiffpy:mainfrom
ycexiao:tutorial_data_temperature
Closed
docs: add temperature field to tutorial data#171ycexiao wants to merge 3 commits intodiffpy:mainfrom ycexiao:tutorial_data_temperature
ycexiao wants to merge 3 commits intodiffpy:mainfrom
ycexiao:tutorial_data_temperature
Conversation
Collaborator
Author
|
@sbillinge It's ready for review. I think the data should be update as soon as possible and I will open another issue to suggest a feature that can take file names as an input to extract meta data. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
=======================================
Coverage 96.85% 96.85%
=======================================
Files 18 18
Lines 795 795
=======================================
Hits 770 770
Misses 25 25 🚀 New features to boost your workflow:
|
sbillinge
reviewed
Mar 19, 2025
news/data_temperature.rst
Outdated
| @@ -0,0 +1,23 @@ | |||
| **Added:** | |||
|
|
|||
| * add temperature field to tutorial/additionalData. | |||
Contributor
There was a problem hiding this comment.
this should be in fixed. This is not an added functionality.
Collaborator
Author
|
codecov will go wrong because the upstream name changed. Redo the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #169