fix: import loadData and deserialize_data directly to adopt new API from diffpy.utils(3.6.0)#162
fix: import loadData and deserialize_data directly to adopt new API from diffpy.utils(3.6.0)#162sbillinge merged 3 commits intodiffpy:mainfrom ycexiao:parser-api
loadData and deserialize_data directly to adopt new API from diffpy.utils(3.6.0)#162Conversation
|
@sbillinge It's ready for review, thank you. |
|
This looks like a better solution - assuming local test and GH pass. |
|
@ycexiao also the PR title can be a bit clarified. The only use information in the title is "new" - we might want to add information that this PR directly imports loaddata and deserializae methods from diffpy.util 3.6.0 (also news should be clarified that it's an API update to be compatiable with diffpy.utils 3.6.0) |
parsers apiloadData and deserialize_data directly to adopt new API from diffpy.utils(3.6.0)
Thank you. Details have been added to issue title and news |
|
Thanks @ycexiao , good changes! I like it. |
news/new_parser_api.rst
Outdated
|
|
||
| **Changed:** | ||
|
|
||
| * import `loadData` and `deserialize_data` directly to integrate with `diffpy.utils(3.6.0)` |
There was a problem hiding this comment.
please move to fixed. this is a fix (bug) not a change (change in behavior of the program that users need to know about)
There was a problem hiding this comment.
Thank you. Updates have been pushed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
=======================================
Coverage 96.85% 96.85%
=======================================
Files 18 18
Lines 795 795
=======================================
Hits 770 770
Misses 25 25 |
|
@sbillinge It's ready for another review. |
|
Amazing! @ycexiao |
close #161