Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
+ Coverage 96.85% 96.87% +0.02%
==========================================
Files 18 18
Lines 795 801 +6
==========================================
+ Hits 770 776 +6
Misses 25 25
🚀 New features to boost your workflow:
|
sbillinge
left a comment
There was a problem hiding this comment.
this probably needs tests, or is it being tested but the tests didn't need to be changed. If so, ere they failing before? If not they need to be extended....
|
Yes, tests needed. I think adding 2 directories with blank files to testsequence is sufficient if the tests still pass as there is no specific output given when directories are parsed out. |
|
Tests pass. Good to merge? |
| @@ -0,0 +1 @@ | |||
| This directory should be ignored by PDFmorph. | |||
There was a problem hiding this comment.
can we not do it with tmpdir dynamically in the test? We normally wouldn't do it this way by creating junk in the source repo.
|
Closing for fresh bugfix branch. |
Used to break for multiple subdirectories within the many-morphs directories.