Use std::string_view in cmdlinet#9098
Draft
kroening wants to merge 2 commits into
Draft
Conversation
The strings given as arguments to the methods in levenshtein_automatont are not copied, and their address is not taken. Hence, a std::string_view suffices.
The strings passed as argument to the methods in cmdlinet are frequently not copied, and their address is not taken. Hence, in those cases, use std::string_view instead of std::string to relieve the caller from the burden of constructing the std::string object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The strings passed as argument to the methods in
cmdlinetare frequently not copied, and their address is not taken. Hence, in those cases, usestd::string_viewinstead ofstd::stringto relieve the caller from the burden of constructing thestd::stringobject.