move range_typet to mathematical_types.h#9000
Merged
Conversation
kroening
requested review from
TGWDB,
martin-cs,
peterschrammel,
remi-delmas-3000 and
tautschnig
as code owners
peterschrammel
approved these changes
May 5, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9000 +/- ##
========================================
Coverage 80.52% 80.52%
========================================
Files 1705 1705
Lines 188927 188927
Branches 73 73
========================================
Hits 152136 152136
Misses 36791 36791 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
feliperodri
approved these changes
May 5, 2026
The header file mathematical_types.h is a better fit for range_typet, the type for subranges of integers.
In mathematical_types.h the declarations of set_from, set_to and the range_typet constructor used a mix of '_from'/'_to' (with leading underscore) and 'from'/'to'. The definitions in mathematical_types.cpp consistently use 'from'/'to' without the leading underscore. Drop the underscores from the header so that both files agree on a single style, which makes the signatures easier to read and keeps IDE/Doxygen output consistent. Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
The previous one-line description ('A type for subranges of integers')
did not state that the interval is closed on both ends, and it did not
document the preconditions on zero_expr() / one_expr() that are enforced
at runtime via PRECONDITION. Add class- and method-level Doxygen that
makes inclusivity explicit and spells out that zero_expr() / one_expr()
require 0 / 1 to lie within the interval.
No behavioural change.
Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
tautschnig
force-pushed
the
move-range_typet
branch
from
c201afd to
6d57b8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header file
mathematical_types.his a better fit forrange_typet, the type for subranges of integers.