Skip to content

Initialise all POD members of goto_symex_statet#8865

Merged
kroening merged 1 commit intodiffblue:developfrom
tautschnig:asan-fixes/symex_init
Mar 16, 2026
Merged

Initialise all POD members of goto_symex_statet#8865
kroening merged 1 commit intodiffblue:developfrom
tautschnig:asan-fixes/symex_init

Conversation

@tautschnig
Copy link
Collaborator

The constructor did not take care of them and our unit tests exposed that, at least within unit tests, we were accessing uninitialised members.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The constructor did not take care of them and our unit tests exposed
that, at least within unit tests, we were accessing uninitialised
members.
@tautschnig tautschnig self-assigned this Mar 15, 2026
Copilot AI review requested due to automatic review settings March 15, 2026 21:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes undefined behavior in unit tests by ensuring previously uninitialized POD members of goto_symex_statet are deterministically initialized.

Changes:

  • Initialize symex_target to nullptr in-class.
  • Initialize jump-target/next-instruction state flags to false.
  • Initialize run_validation_checks to false.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Mar 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.01%. Comparing base (7a4df92) to head (29c23f5).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8865   +/-   ##
========================================
  Coverage    80.01%   80.01%           
========================================
  Files         1703     1703           
  Lines       188396   188396           
  Branches        73       73           
========================================
  Hits        150738   150738           
  Misses       37658    37658           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kroening kroening merged commit a9df9c6 into diffblue:develop Mar 16, 2026
45 checks passed
@tautschnig tautschnig deleted the asan-fixes/symex_init branch March 16, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants