Initialise message_handler in bv_refinement unit test#8863
Merged
kroening merged 2 commits intodiffblue:developfrom Mar 16, 2026
Merged
Initialise message_handler in bv_refinement unit test#8863kroening merged 2 commits intodiffblue:developfrom
kroening merged 2 commits intodiffblue:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes undefined behavior in a JBMC unit test by ensuring bv_refinementt::infot::message_handler is initialized before being dereferenced.
Changes:
- Initialize
bv_refinementt::infot::message_handlertonull_message_handlerin theinstantiate_not_containsunit test helper.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8863 +/- ##
===========================================
+ Coverage 80.00% 80.41% +0.40%
===========================================
Files 1703 1703
Lines 188397 188398 +1
Branches 73 73
===========================================
+ Hits 150736 151496 +760
+ Misses 37661 36902 -759 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The message_handler member of bv_refinementt::infot was left uninitialised, which is undefined behaviour when it is later dereferenced. Set it to null_message_handler. Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
These tests were missing the CORE label, so they were excluded from coverage collection (ctest -V -L CORE). This meant XFAIL test code never executed during coverage runs, producing 0% coverage for any changes to XFAIL tests. Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
942d70e to
ec7cebe
Compare
kroening
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The message_handler member of bv_refinementt::infot was left uninitialised, which is undefined behaviour when it is later dereferenced. Set it to null_message_handler.