Use cmake for cleaning in cmake job#8547
Merged
tautschnig merged 1 commit intodiffblue:developfrom May 6, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8547 +/- ##
========================================
Coverage 80.52% 80.52%
========================================
Files 1705 1705
Lines 188927 188927
Branches 73 73
========================================
Hits 152130 152130
Misses 36797 36797 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tautschnig
approved these changes
May 4, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the CMake-based CI cleanup flow so the check-ubuntu-24_04-cmake-gcc job uses cmake --build ... --target clean instead of Make-based clean commands, while teaching CMake about a few source-tree artifacts that need removal.
Changes:
- Register
scripts/bash-autocomplete/cbmc.shas an additional clean file for thecbmc.shcustom target. - Register top-level regression log files as additional clean files in the CMake regression targets.
- Replace the workflow’s manual
make ... cleancleanup commands withcmake --build build --target cleanplus targetedfind ... -deletecleanup.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/cbmc/CMakeLists.txt |
Adds CMake clean metadata for the generated bash completion script. |
regression/CMakeLists.txt |
Adds CMake clean metadata for the top-level regression log file. |
jbmc/CMakeLists.txt |
Adds CMake clean metadata for Java regression outputs and log files. |
.github/workflows/pull-request-checks.yaml |
Switches the CMake CI job’s cleanup step from Make-based cleaning to CMake-based cleaning plus manual artifact deletion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
885fada to
59c4b35
Compare
Move cbmc.sh cleanup into ADDITIONAL_CLEAN_FILES on the cbmc.sh target so cmake clean handles it. The .log files are already covered by ADDITIONAL_CLEAN_FILES in regression/ and jbmc/ CMakeLists. Only the per-test artifacts (.out, .gb, .goto, .dimacs, .json) need find at runtime since they are generated after cmake configure. Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of make
Based on #8487