Skip to content

Use cmake for cleaning in cmake job#8547

Merged
tautschnig merged 1 commit intodiffblue:developfrom
peterschrammel:ps/cmake-clean
May 6, 2026
Merged

Use cmake for cleaning in cmake job#8547
tautschnig merged 1 commit intodiffblue:developfrom
peterschrammel:ps/cmake-clean

Conversation

@peterschrammel
Copy link
Copy Markdown
Member

@peterschrammel peterschrammel commented Dec 30, 2024

instead of make

Based on #8487

  • Each commit message has a non-empty body, explaining why the change was made.
  • [n/a] Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • [n/a] The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • [n/a] Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [n/a] My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • [n/a] White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 30, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.52%. Comparing base (5556082) to head (7bec581).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8547   +/-   ##
========================================
  Coverage    80.52%   80.52%           
========================================
  Files         1705     1705           
  Lines       188927   188927           
  Branches        73       73           
========================================
  Hits        152130   152130           
  Misses       36797    36797           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tautschnig tautschnig marked this pull request as ready for review May 4, 2026 11:37
Copilot AI review requested due to automatic review settings May 4, 2026 11:37
@tautschnig tautschnig requested review from a team and kroening as code owners May 4, 2026 11:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CMake-based CI cleanup flow so the check-ubuntu-24_04-cmake-gcc job uses cmake --build ... --target clean instead of Make-based clean commands, while teaching CMake about a few source-tree artifacts that need removal.

Changes:

  • Register scripts/bash-autocomplete/cbmc.sh as an additional clean file for the cbmc.sh custom target.
  • Register top-level regression log files as additional clean files in the CMake regression targets.
  • Replace the workflow’s manual make ... clean cleanup commands with cmake --build build --target clean plus targeted find ... -delete cleanup.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/cbmc/CMakeLists.txt Adds CMake clean metadata for the generated bash completion script.
regression/CMakeLists.txt Adds CMake clean metadata for the top-level regression log file.
jbmc/CMakeLists.txt Adds CMake clean metadata for Java regression outputs and log files.
.github/workflows/pull-request-checks.yaml Switches the CMake CI job’s cleanup step from Make-based cleaning to CMake-based cleaning plus manual artifact deletion.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/pull-request-checks.yaml Outdated
@tautschnig tautschnig force-pushed the ps/cmake-clean branch 5 times, most recently from 885fada to 59c4b35 Compare May 5, 2026 16:34
Move cbmc.sh cleanup into ADDITIONAL_CLEAN_FILES on the cbmc.sh target
so cmake clean handles it. The .log files are already covered by
ADDITIONAL_CLEAN_FILES in regression/ and jbmc/ CMakeLists. Only the
per-test artifacts (.out, .gb, .goto, .dimacs, .json) need find at
runtime since they are generated after cmake configure.

Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
@tautschnig tautschnig merged commit 66f8c1b into diffblue:develop May 6, 2026
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants