Skip to content

ci: isolate riscv build failure from non-riscv merge jobs#11

Merged
dictcp merged 1 commit into
masterfrom
claude/gracious-hawking-mGIT9
May 29, 2026
Merged

ci: isolate riscv build failure from non-riscv merge jobs#11
dictcp merged 1 commit into
masterfrom
claude/gracious-hawking-mGIT9

Conversation

@dictcp
Copy link
Copy Markdown
Owner

@dictcp dictcp commented May 29, 2026

Summary

  • Add a job-level if condition to the merge job so a build-riscv failure (e.g. RISE runner outage) only blocks the ubuntu2604 merge — all other targets (full, ubuntu2404, ubuntu2204, alpine) continue as long as build-amd64 and build-arm pass.

Before / after

Before: build-riscv failure → all 5 merge matrix jobs skipped
After: build-riscv failure → only ubuntu2604 merge skipped; other 4 targets unaffected

Condition logic

if: |
  always() &&
  needs.build-amd64.result == 'success' &&
  needs.build-arm.result == 'success' &&
  (matrix.target != 'ubuntu2604' || needs.build-riscv.result == 'success')

Test plan

  • Simulate build-riscv failure and confirm full, ubuntu2404, ubuntu2204, alpine merge jobs still complete
  • Confirm ubuntu2604 merge is correctly skipped when build-riscv fails

Generated by Claude Code

A build-riscv failure (e.g. RISE runner outage) previously caused all
merge matrix jobs to be skipped. Add a job-level if condition so that
only the ubuntu2604 merge job requires build-riscv to succeed; all
other targets proceed as long as build-amd64 and build-arm pass.

https://claude.ai/code/session_01Nr2cib6QkdXxvTFGWVHurp
@dictcp dictcp merged commit 6b8d910 into master May 29, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe0d422df2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

always() &&
needs.build-amd64.result == 'success' &&
needs.build-arm.result == 'success' &&
(matrix.target != 'ubuntu2604' || needs.build-riscv.result == 'success')
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Move matrix-dependent condition out of job if

In GitHub Actions, jobs.<job_id>.if is evaluated before strategy.matrix is applied, so matrix.target is not available in this job-level condition. In the inspected .github/workflows/main.yml merge job, this makes the new condition invalid or unable to distinguish ubuntu2604, so the workflow will not achieve the intended behavior of allowing the other merge targets to continue when build-riscv fails; split the merge jobs or move the target-specific gating to a place where the matrix context exists.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants