Skip to content

Add subtitles to movies#8394

Open
yuripourre wants to merge 13 commits intodiasurgical:masterfrom
yuripourre:subtitles
Open

Add subtitles to movies#8394
yuripourre wants to merge 13 commits intodiasurgical:masterfrom
yuripourre:subtitles

Conversation

@yuripourre
Copy link
Copy Markdown
Collaborator

@yuripourre yuripourre commented Dec 31, 2025

This is my attempt to add subtitles to movies.

Thanks @StephenCWills for helping me.
I can load the subtitles but tried hard to render the subtitles over the movie but I simply can't.
Maybe someone can help me here?

I added a new library following the project standards.

The way the translation works is: for each movie we need a str file with the translation with the same name as the movie but with a different extension.

The translation script iterates over the str files and extracts the sentences so they can be translated in the .po files.

outsub.mp4

@kphoenix137 kphoenix137 added the help wanted Extra attention is needed label Dec 31, 2025
@StephenCWills
Copy link
Copy Markdown
Member

StephenCWills commented Dec 31, 2025

Your comment on line 310 suggests you are trying to blit subtitles onto SVidSurface before SDL_BlitSurface() is called on line 241. Have you tried moving subtitle rendering up, to the beginning of that function?

@yuripourre
Copy link
Copy Markdown
Collaborator Author

Your comment on line 310 suggests you are trying to blit subtitles onto SVidSurface before SDL_BlitSurface() is called on line 241. Have you tried moving subtitle rendering up, to the beginning of that function?

It worked!! Thank you do much @StephenCWills

@yuripourre yuripourre marked this pull request as ready for review January 21, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants