Add subtitles to movies#8394
Open
yuripourre wants to merge 13 commits intodiasurgical:masterfrom
Open
Conversation
Member
|
Your comment on line 310 suggests you are trying to blit subtitles onto |
Collaborator
Author
It worked!! Thank you do much @StephenCWills |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt to add subtitles to movies.
Thanks @StephenCWills for helping me.
I can load the subtitles but tried hard to render the subtitles over the movie but I simply can't.Maybe someone can help me here?
I added a new library following the project standards.
The way the translation works is: for each movie we need a str file with the translation with the same name as the movie but with a different extension.
The translation script iterates over the str files and extracts the sentences so they can be translated in the .po files.
outsub.mp4