[QOL/Accessibility] Broken Item Sounds

[kphoenix137]

Adds the unused sound effects armrfkd.wav (armor f**ked), Swrdfkd.wav (sword f**ked), hlmtfkd.wav (helmet f**ked), and shielfkd.wav (shield f**ked) to be played when items are destroyed at 0 durability. Provides auditory feedback to the player to assist with giving a clear indicator that an item broke, which also works as an accessibility feature for the visually impaired. Unobtrusive enough to not require a toggle (in my opinion).

[qndel]

Maybe you could come up with some nice refactor that calls some function in all these places which handles

			RemoveEquipment(player, INVLOC_HAND_LEFT, true);
			CalcPlrInv(player, true);
			PlaySfxLoc(SfxID::BrokeShield, player.position.tile);

?

also any idea why last 2 places don't call CalcPlrInv(player, true); ? Maybe a potential bug there? :D

[kphoenix137]

Maybe you could come up with some nice refactor that calls some function in all these places which handles

			RemoveEquipment(player, INVLOC_HAND_LEFT, true);
			CalcPlrInv(player, true);
			PlaySfxLoc(SfxID::BrokeShield, player.position.tile);

?

also any idea why last 2 places don't call CalcPlrInv(player, true); ? Maybe a potential bug there? :D

CalcPlrInv isn't needed whenever just durability changes, and the item isn't destroyed because nothing changes (no graphic change, or character stat changes).

Also, I have refactored these functions already:
#8387
#8386
#8385

[qndel]

nvm I've expanded the code down and see CalcPlrInv(player, true); is there, just below :D

[StephenCWills]

Does anyone see an issue with playing shielfkd.wav when Monk blocks and loses his staff?

[strich]

Does anyone see an issue with playing shielfkd.wav when Monk blocks and loses his staff?

Yeah I think that's a good shout!